On Mon, Sep 12, 2011 at 11:56:55PM +0800, Pang Yan Han wrote: > Hi, I don't know if I actually understand the naming convention for tests > correctly here, so I used the next available number for the last 2 digits. > > t/t4051-format-patch-color.sh | 23 +++++++++++++++++++++++ Usually we would try to keep format-patch tests clustered numerically, but it seems the t40* space has gotten quite filled up and fragmented. So I think where you added it is fine (and if somebody cares to reorganize tests, they can do so later). Often if there is only one or two tests to add, it is more logical to add to an existing script. However, I think in this case, starting a new script to check how format-patch handles various config features (including color) makes sense. Maybe it makes sense to call it "format-patch-config" instead, and set the description to something like "check that format-patch does not respect porcelain config". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html