commit c9bfb953 (want_color: automatically fallback to color.ui) introduced a regression where format-patch produces colorized patches when color.ui is set to "always". Demonstrate this through a new test. Signed-off-by: Pang Yan Han <pangyanhan@xxxxxxxxx> --- Hi, I don't know if I actually understand the naming convention for tests correctly here, so I used the next available number for the last 2 digits. t/t4051-format-patch-color.sh | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) create mode 100755 t/t4051-format-patch-color.sh diff --git a/t/t4051-format-patch-color.sh b/t/t4051-format-patch-color.sh new file mode 100755 index 0000000..db30840 --- /dev/null +++ b/t/t4051-format-patch-color.sh @@ -0,0 +1,23 @@ +#!/bin/sh + +test_description='format-patch - check for non colorized output' + +. ./test-lib.sh + +test_expect_success setup ' + echo foo >foo && + git add foo && + git commit -m "commit1" && + echo bar >foo && + git add foo && + git commit -m "commit2" +' + +test_expect_failure 'format patch with ui.color=always generates non colorized patch' ' + git config color.ui always && + git format-patch -1 && + mv 0001-commit2.patch actual && + test_must_fail grep "\[31m-" actual +' + +test_done -- 1.7.7.rc0.190.g816e -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html