On Tue, Aug 30, 2011 at 11:43:44AM +0200, Michael J Gruber wrote: > > When grabbing a %(body) or %(contents) off a tag, one doesn't really > > expect to get the GPG signature as well (as it's basically useless > > without the complete signed text). Thus, strip it off those two tags, > > and make available via %(signature) if anyone needs it. > > No, please do not change %(contents). It is the complete content which > (together with the header) enters into the sha1 calculation. > > You will probably also face opposition as regards to %(body), changing > existing behaviour. Yeah. If it were 2005, I think it might make sense to have non-overlapping individual keys to get each part of the tag. But it's not worth breaking backwards compatibility of "%(body)" today. So it has to remain as-is, and we have to introduce a new key for "the body without the signature". > In fact, I wish we didn't have %(body) but %(contents:body) just like > other modifiers such as :short. > > I think I'd go for > > %(contents:signature) That makes some sense to me, though it is a little weird that the ":signature" modifier works only for tags, and not commits. In other cases, whole keys either work or don't work (e.g., "taggerdate"). But I guess it is not that big a deal. > %(contents:subject) the same as %(subject) > %(contents:body) as contents minus subject minus signature > > and slowly deprecate %(subject) and %(body) (simply un-document for now). That leaves no way to get what "%(body)" provides now, right? I wonder if anyone cares. You can always ask for: %(contents:body)%(contents:signature) I guess. > > + /* look for GPG signature */ > > Again I have to say no. Please look at > > 3d5854e (tag: recognize rfc1991 signatures, 2010-11-10) > > which uses the factored out signature detection as introduced in the > previous commits. Thanks! Yeah. More correct, and it's less code, too. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html