Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > >> The uninitialized variable seems harmless in practice, but let's still be clean. > > It is not "in practice", but by definition, file scope "static int" > variables are initialized to 0 by the C language OK, I didn't know this was specified in C, but you're right. > Please do not write unnecessary " = 0" there. I prefer being explicit, but that's a matter of taste, and I don't really care, so let's drop this patch. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html