Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > The uninitialized variable seems harmless in practice, but let's still be clean. It is not "in practice", but by definition, file scope "static int" variables are initialized to 0 by the C language (a typical implementation achieves this by placing the variable in BSS section). Please do not write unnecessary " = 0" there. > > Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> > --- > For some reason, remote helpers seem to be forced to use the "done" > command now. Investing why, I found this, but that wasn't what I was > looking for. > > fast-import.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fast-import.c b/fast-import.c > index 7cc2262..ed8f3cd 100644 > --- a/fast-import.c > +++ b/fast-import.c > @@ -355,7 +355,7 @@ static unsigned int cmd_save = 100; > static uintmax_t next_mark; > static struct strbuf new_data = STRBUF_INIT; > static int seen_data_command; > -static int require_explicit_termination; > +static int require_explicit_termination = 0; > > /* Signal handling */ > static volatile sig_atomic_t checkpoint_requested; -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html