On Fri, Aug 12, 2011 at 1:00 AM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote: > Am 8/12/2011 7:20, schrieb Elijah Newren: >> Here's an attempt for a delete_item API (note: only compile-tested). > > Seriously? You haven't even tested this patch, and still don't mark it > with RFC? > >> Bike-shed painters welcome: delete_item, remove_item, free_item? > > You should know that a sentence like this shouldn't appear in the commit > message. > > Yeah, I know, you just copy-pasted my email text. But that was not a > commit message. Perhaps like this: You are right. I apologize; I messed up here. However, I am unclear what you mean by not even testing the patch, though. I couldn't find any unit-test harness or any other kind of testsuite for the string_list API. I did review the code to make sure it looked right to me, added a use of your new function, and ran the standard testsuite in addition to my "re-merge all merges from git.git" testcase. I even single stepped through the code in a debugger for good measure. What testing did you want to see in particular? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html