Ramkumar Ramachandra wrote:
> +++ b/sequencer.c
> @@ -1,8 +1,809 @@
[...]
> +static const char * const revert_usage[] = {
> + "git revert [options] <commit-ish>",
> + "git revert <subcommand>",
> + NULL
> +};
[...]
> +++ b/sequencer.h
[...]
> @@ -25,4 +50,7 @@ struct replay_insn_list {
> */
> void remove_sequencer_state(int aggressive);
>
> +void sequencer_parse_args(int argc, const char **argv, struct replay_opts *opts);
Another thought. I wonder if it's possible to leave
sequencer_parse_args() private to builtin/revert.c, making the split
a little more logical:
- the builtin takes responsibility for its commandline interface
- the library takes over once the builtin has figured out what the
user wanted.
(If another command wants to reuse some subset of cherry-pick/revert's
commandline options, an appropriate function can always be exposed
later.)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html