Re: [PATCH 09/18] revert: Don't create invalid replay_opts in parse_args

[Ramkumar Ramachandra <artagnon@xxxxxxxxx>]

Hi Christian,

Christian Couder writes:
> ... and we could remove the "set" variable like this:
>
>        while ((this_opt = va_arg(ap, const char *))) {
>                if (va_arg(ap, int))
>                        break;
>        }

Very elegant- I especially like this.
You've reduced this to simply checking if the while loop ended
properly, or broke (using a break statement) by checking the
conditional that drove the loop.

Thanks.

-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html