Ramkumar Ramachandra wrote:
> Allow arbitrary sequencer instructions in the instruction sheet.
"So now I can ..." wait, what does this allow me to do? Your audience
hasn't read the patch yet.
> --- a/sequencer.h
> +++ b/sequencer.h
> @@ -32,6 +32,16 @@ struct replay_opts {
> size_t xopts_nr, xopts_alloc;
> };
>
> +struct replay_insn {
> + struct commit *commit;
> + enum replay_action action;
> +};
> +
> +struct replay_insn_list {
> + struct replay_insn *item;
> + struct replay_insn_list *next;
> +};
Ah, so this allows sequences like
revert A
pick B
pick C
revert D
Nit: why isn't the list-item struct something like
struct replay_insn item;
struct replay_insn_list *next;
which would save a little memory management and memory access
overhead (or even
enum replay_action action;
struct commit *operand;
struct replay_insn_list *next;
since every "struct replay_insn" exists in the context of an
insn list afaict)?
Anyway, the general idea seems good.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html