On Tue, Aug 2, 2011 at 11:00 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Dmitry Ivankov <divanorama@xxxxxxxxx> writes: > >> Neither name nor email should contain < or >, so split the string with >> these and check they come in that order and < is preceeded with a space. >> >> If < is missing don't say a confusing "missing space", say "bad name" if >>> isn't missing and "missing email" if both < and > are missing. >> >> Signed-off-by: Dmitry Ivankov <divanorama@xxxxxxxxx> >> --- > > Same comment as 3/5; before starting to talk about how you implemented > your validation, please state what rules you are enforcing. Thanks, will apply and reroll. But before this, is it ok to reject "Name> <email>" idents in fsck and fast-import? fsck already denies '<' and '>' inside email, and '<' in name. But accepts '>' in name. It just hit me that Documentation/fast-import.c doesn't deny '>' in name and it is consistent with fsck, so there may be a reason behind it. > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html