On Tue, Aug 2, 2011 at 10:16 PM, Christian Couder
<christian.couder@xxxxxxxxx> wrote:
> On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
>> If --no-checkout is specified, then the bisection process uses:
>
> Yeah, but in this patch you are changing "git bisect--helper" by
> adding the [--bisect-mode=checkout|update-ref] option. So it is
> strange that you still talk about a --no-checkout option.
>
>> git update-ref --no-deref HEAD <trial>
>>
>> at each trial instead of:
>>
>> git checkout <trial>
>
> [...]
>
>> int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>> {
>> int next_all = 0;
>> + int no_checkout = 0;
>> + char *bisect_mode=NULL;
>> struct option options[] = {
>> OPT_BOOLEAN(0, "next-all", &next_all,
>> "perform 'git bisect next'"),
>> + OPT_STRING(0, "bisect-mode", &bisect_mode, "mode",
>> + "the bisection mode either checkout or update-ref. defaults to checkout."),
>
> Nit: I would say : "bisection mode: 'checkout' (default) or 'update-ref'"
>
Thanks. Will address iboth comments s a future iteration.
jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html