On Tue, Aug 2, 2011 at 10:04 PM, Christian Couder <christian.couder@xxxxxxxxx> wrote: > On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote: >> @@ -34,6 +34,8 @@ require_work_tree >> _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]' >> _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40" >> >> +BISECT_MODE=$(test -f "$GIT_DIR/BISECT_MODE" && cat "$GIT_DIR/BISECT_MODE") > > Could you put this line just where it is needed, that is in > bisect_next() and bisect_reset()? > Ultimately, it is also needed in paths that call bisect_state(), such as bisect_run() and bisect_skip() so I am not keen to do this. If I was to do this, I'd prefer to change uses of $BISECT_MODE with a call to a function bisect_mode() that does the same thing. jon. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html