On Tuesday 02 August 2011 04:47:01 Christian Couder wrote: > We can simplify this loop using strchrnul() like this: > > for (i = 1; *p; i++) { > struct commit *commit = parse_insn_line(p, opts); > if (!commit) > return error(_("Could not parse line %d."), i); > next = commit_list_append(commit, next); > p = strchrnul(p, '\n'); > } Ooops, sorry I mean like this: for (i = 1; *p; i++) { struct commit *commit = parse_insn_line(p, opts); if (!commit) return error(_("Could not parse line %d."), i); next = commit_list_append(commit, next); p = strchrnul(p, '\n'); if (*p) p++; } Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html