On 8/1/2011 11:06 AM, Jeff King wrote:
I think he means that auto-pluralization like this cannot be done in an i18n world, as many languages do not simply add "s". Your patch would have to use ngettext, something like this (totally untested and just copying a similar spot in suggest_reattach, as I have never done any i18n myself):
[snip]
And that gives translators a chance to specify the entire singular and plural versions separately.
I entirely agree. My point is only that the various tests that expect the current behavior will have to be changed whether the implementation of correct plurals uses my inferior method or the way more correct i18n method. Jon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html