On Mon, Aug 1, 2011 at 6:07 AM, Christian Couder
<chriscool@xxxxxxxxxxxxx> wrote:
> On Sunday 31 July 2011 21:40:35 Jon Seymour wrote:
>> On Mon, Aug 1, 2011 at 5:21 AM, Christian Couder
>>
>> <christian.couder@xxxxxxxxx> wrote:
>> > On Sun, Jul 31, 2011 at 1:55 PM, Jon Seymour <jon.seymour@xxxxxxxxx>
> wrote:
>> >> + if test -n "$BISECT_UPDATE_REF"; then
>> >> + eval="$eval echo '$BISECT_UPDATE_REF' >
>> >> '$GIT_DIR/BISECT_UPDATE_REF';" + fi
>> >
>> > I don't like this very much. In fact I realize that the eval thing we
>> > use is buggy because the result of 'eval "eval"' will be the result of
>> > the last command in "eval", so we won't detect if one of the first
>> > command in "eval" failed.
>>
>> How about I fix the eval stitching so that it uses && rather than ; to
>> connect each statement with a final true at the end so there is no
>> dangling &&?
>
> Yeah, please fix it in a separate bug fix patch.
>
Next roll-up will contain this as patch 2:
- eval="$eval bisect_write '$state' '$rev' 'nolog'; "
+ eval="$eval ${eval:+&&} bisect_write '$state' '$rev' 'nolog' "
There is a no-checkout-v10 tag on github with the current iteration
(https://github.com/jonseymour/git/commits/no-checkout-v10).
This also contains the v8a patch.
I'll repost on request or once others have had the chance to give feedback.
jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html