On Sun, Jul 31, 2011 at 1:55 PM, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
>
> + if test -n "$BISECT_UPDATE_REF"; then
> + eval="$eval echo '$BISECT_UPDATE_REF' > '$GIT_DIR/BISECT_UPDATE_REF';"
> + fi
I don't like this very much. In fact I realize that the eval thing we
use is buggy because the result of 'eval "eval"' will be the result of
the last command in "eval", so we won't detect if one of the first
command in "eval" failed.
So perhaps something like:
eval "$eval" &&
+ ( test -n "$BISECT_UPDATE_REF" || echo "$BISECT_UPDATE_REF" >
"$GIT_DIR/BISECT_UPDATE_REF" ) &&
echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit
Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html