The decoration API maps objects to void pointers. This is a
subset of what the map API is capable of, so let's get rid
of the duplicate implementation.
We could just fix all callers of decorate to call the map
API directly. However, the map API is very generic since it
is meant to handle any type. In particular, it can't use
sentinel values like "NULL" to indicate "entry not found"
(since it doesn't know whether the type can represent such a
sentinel value).
Instead, the decorate API just becomes a set of wrappers,
and no callers need to be updated at all.
Signed-off-by: Jeff King <peff@xxxxxxxx>
---
The result should perform identically to the existing decorate code with
the exception of the extra "used" field, which makes each hash entry
bigger (see the comments in patch 1/3).
decorate.c | 105 ++++++++++--------------------------------------------------
decorate.h | 10 ++----
map.c | 1 +
map.h | 1 +
4 files changed, 22 insertions(+), 95 deletions(-)
rewrite decorate.c (89%)
diff --git a/decorate.c b/decorate.c
dissimilarity index 89%
index 2f8a63e..31e9656 100644
--- a/decorate.c
+++ b/decorate.c
@@ -1,88 +1,17 @@
-/*
- * decorate.c - decorate a git object with some arbitrary
- * data.
- */
-#include "cache.h"
-#include "object.h"
-#include "decorate.h"
-
-static unsigned int hash_obj(const struct object *obj, unsigned int n)
-{
- unsigned int hash;
-
- memcpy(&hash, obj->sha1, sizeof(unsigned int));
- return hash % n;
-}
-
-static void *insert_decoration(struct decoration *n, const struct object *base, void *decoration)
-{
- int size = n->size;
- struct object_decoration *hash = n->hash;
- unsigned int j = hash_obj(base, size);
-
- while (hash[j].base) {
- if (hash[j].base == base) {
- void *old = hash[j].decoration;
- hash[j].decoration = decoration;
- return old;
- }
- if (++j >= size)
- j = 0;
- }
- hash[j].base = base;
- hash[j].decoration = decoration;
- n->nr++;
- return NULL;
-}
-
-static void grow_decoration(struct decoration *n)
-{
- int i;
- int old_size = n->size;
- struct object_decoration *old_hash = n->hash;
-
- n->size = (old_size + 1000) * 3 / 2;
- n->hash = xcalloc(n->size, sizeof(struct object_decoration));
- n->nr = 0;
-
- for (i = 0; i < old_size; i++) {
- const struct object *base = old_hash[i].base;
- void *decoration = old_hash[i].decoration;
-
- if (!base)
- continue;
- insert_decoration(n, base, decoration);
- }
- free(old_hash);
-}
-
-/* Add a decoration pointer, return any old one */
-void *add_decoration(struct decoration *n, const struct object *obj,
- void *decoration)
-{
- int nr = n->nr + 1;
-
- if (nr > n->size * 2 / 3)
- grow_decoration(n);
- return insert_decoration(n, obj, decoration);
-}
-
-/* Lookup a decoration pointer */
-void *lookup_decoration(struct decoration *n, const struct object *obj)
-{
- unsigned int j;
-
- /* nothing to lookup */
- if (!n->size)
- return NULL;
- j = hash_obj(obj, n->size);
- for (;;) {
- struct object_decoration *ref = n->hash + j;
- if (ref->base == obj)
- return ref->decoration;
- if (!ref->base)
- return NULL;
- if (++j == n->size)
- j = 0;
- }
-}
+#include "cache.h"
+#include "decorate.h"
+
+void *add_decoration(struct decoration *n, const struct object *obj,
+ void *decoration)
+{
+ void *ret = NULL;
+ map_set_object_void(&n->map, obj, decoration, &ret);
+ return ret;
+}
+
+void *lookup_decoration(struct decoration *n, const struct object *obj)
+{
+ void *ret = NULL;
+ map_get_object_void(&n->map, obj, &ret);
+ return ret;
+}
diff --git a/decorate.h b/decorate.h
index e732804..6a3adcd 100644
--- a/decorate.h
+++ b/decorate.h
@@ -1,15 +1,11 @@
#ifndef DECORATE_H
#define DECORATE_H
-struct object_decoration {
- const struct object *base;
- void *decoration;
-};
+#include "map.h"
struct decoration {
- const char *name;
- unsigned int size, nr;
- struct object_decoration *hash;
+ char *name;
+ struct map_object_void map;
};
extern void *add_decoration(struct decoration *n, const struct object *obj, void *decoration);
diff --git a/map.c b/map.c
index 28f885e..93e0364 100644
--- a/map.c
+++ b/map.c
@@ -86,3 +86,4 @@ int map_get_##name(struct map_##name *m, \
}
MAP_IMPLEMENT(object_uint32, struct object *, uint32_t, cmp_obj, hash_obj)
+MAP_IMPLEMENT(object_void, struct object *, void *, cmp_obj, hash_obj)
diff --git a/map.h b/map.h
index e80d85d..737054e 100644
--- a/map.h
+++ b/map.h
@@ -22,5 +22,6 @@ extern int map_set_##name(struct map_##name *, \
vtype *old); \
DECLARE_MAP(object_uint32, struct object *, uint32_t)
+DECLARE_MAP(object_void, struct object *, void *)
#endif /* MAP_H */
--
1.7.6.38.ge5b33
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html