Ramkumar Ramachandra wrote: > I should have done this earlier. Thanks for being so patient :) > > revert: Don't check lone argument in get_encoding > > The get_encoding function has only one callsite, and its caller makes > sure that a NULL argument isn't passed. Don't unnecessarily double > check the same argument in get_encoding. As a result, avoid passing > "commit" around, and remove a string marked for translation that will > never be shown. Getting closer. This still leaves the motivation unclear --- when I read it it sounds to me like you're saying that avoiding unnecessary code is the motivation, and that not passing "commit" around and removing a string marked for translation are means to that end. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html