Hi, Ramkumar Ramachandra wrote: > The get_encoding function has only one callsite, and its caller makes > sure that a NULL argument isn't passed. Don't unnecessarily double > check the same argument in get_encoding. Such a double-check is not a huge maintenance burden, is it? As I mentioned at [1], I am guessing the actual motivation is (1) to avoid having to pass "commit" around and (2) to avoid burdening translators with a message that will never be shown. Would it be possible to clarify the commit message so it is no longer necessary to guess? [1] http://thread.gmane.org/gmane.comp.version-control.git/176139/focus=176166 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html