Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>> @@ -412,11 +413,8 @@ static int fetch_with_import(struct transport *transport,
>> sendline(data, &buf);
>> strbuf_reset(&buf);
>> }
>> - if (disconnect_helper(transport))
>> - die("Error while disconnecting helper");
>> if (finish_command(&fastimport))
>> die("Error while running fast-import");
>> -
>
> What is this change about? Is the plan to allow other commands after
> a fetch_with_import? Sounds reasonable; I think it should be
> advertised in the log message, though.
>
> When does the disconnect_helper call happen (to avoid leaks)? Ah, in
> release_helper; phew.
>
> The disconnect_helper call writes the blank line that terminates the
> list of "import %s" commands to start the import, so there would need
> to be a
>
> strbuf_reset(&buf);
> strbuf_addf(&buf, "\n");
> sendline(data, &buf);
>
> in its place.
All sensible suggestions for a potential reroll.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html