Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Side note: a "done" capability doesn't sound like a bad idea, though, > for another reason. The transport-helper could tell fast-import to > expect a "done" command at the end when importing from a remote helper > declaring it, to catch situations in which the pipe prematurely closes > (for example, because the remote helper has segfaulted). > >> I don't see a convention of terminating on a >> blank line in docs, > > Yes, this would be nice to document. > >> only on EOF. Also I can imagine a blank >> line being read in a case of communication error > > A spurious NL, NL, EOF sequence does not sound likely to me. If the > command stream is passing through a noisy channel, there are worse > corruptions to worry about (e.g., fetching to the wrong ref). I think everything you said in this message makes sense, especially the part about "premature EOF detection". The spurious LF is an issue if you are trying to drive the backend by hand for testing, but otherwise probably not. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html