2011/6/8 Jeff King <peff@xxxxxxxx>: > > But if you are parsing "diff", then yes, filenames with high-bit > characters (or special characters like tab or double-quote) may be > quoted C-style, and you should be unquoting them. Or, as Matthieu > suggested, use "-z" to get a NUL-terminated, non-quoted version. Yes, we are parsing "diff". The -z helped a lot with non-iso characters. Everything seems to be working fine now without using uri_escape. The problem is, as Matthieu said, different file systems may handle these characters in file names differently, so in the long run it could be better to use uri_escape / uri_unescape. The problem I run into now is that we are using use encoding 'utf-8' as Jakub suggested. Using this mode, when you uri_escape and uri_unescape a string, you don't get the original string. I must be missing something but my head is kind of fuzzy with all the different existing methods to encode things in utf8 and it is getting pretty late. Thanks a lot to everyone who helped today, a RFC patch should follow tomorrow. -- Jérémie Nikaes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html