Jakub Narebski wrote: > The build-time configuration variables JSMIN and CSSMIN were mentioned > only in Makefile; add their description to gitweb/INSTALL. > > This required moving description of GITWEB_JS up, near GITWEB_CSS and > just introduced CSMIN and JSMIN. Why does this require that? Ah, to make the analogy with GITWEB_CSS clear and because the JSMIN description refers to it. > --- a/gitweb/INSTALL > +++ b/gitweb/INSTALL > @@ -147,6 +147,19 @@ You can specify the following configuration variables when building GIT: [...] > + * CSSMIN, JSMIN > + Invocation of a CSS minifier or a JavaScript minifier, respectively, > + working as a filter (source on standard input, minified result on > + standard output). If set, it is used to generate a minified version of > + 'static/gitweb.css' or 'static/gitweb.js', respectively. *Note* that > + minified files would have *.min.css and *.min.js extension, which is > + important if you also set GITWEB_CSS and/or GITWEB_JS. [No default] When I first read this, I thought it meant these command lines were going to be cooked into the gitweb script and invoked at run time. Maybe (sorry for the rough text): * CSSMIN, JSMIN Command for a CSS minifier or a Javascript minifier, working as a filter [...] These are used if defined to generate smaller, non human-readable versions of 'gitweb/gitweb.css' and 'static/gitweb.js' at 'static/gitweb.min.css' and 'static/gitweb.min.js'. Only the minified versions are installed, which is important if you also set GITWEB_CSS or GITWEB_JS. [No default] Aside from that, looks good. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html