Re: [PATCH] Document the underlying protocol used by shallow repositories and --depth commands.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster <at> pobox.com> writes:

> > +Once all the 'want's and 'shallow's (and optional 'deepen') are
> > +transferred, clients MUST send a flush-pkt. If the client has all
> > +the references on the server, and as much of their commit history
> > +as it is interested in, client flushes and disconnects.
> 
> Hmmmmm, are you describing "everything-local then flush and all-done" in
> do_fetch_pack() with the second sentence? If so, placing the description
> here is misleading. In that case, I do not think any of the find-common
> exchange starting from the "upload-request" phase happens.

No, this refers to the same event which was already described in that document,
which I believe happens from inside find_common. It may just be some confusion
on the meaning of "having a reference" on my part, but the idea was to point out
that the client could flush at this stage even if it doesn't have every commit.

I tried to amend the existing wording but I suppose it was just misleading, so
it's better to write something else entirely.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]