Hi,
Ramsay Jones wrote:
> So, the patch is correct, but (apart from the last sentence) the
> commit message is *absolute rubbish*. I won't bore you with the
> details of my lunacy! :-P
>
> However, I much prefer Jonathan's patch which removes this test
> completely!
Junio, please pull
git://repo.or.cz/git/jrn.git svn-fe-maint
to receive the following fix. The patch first visited the list two
months ago[1] and was discussed again last month[2] and seems to have
been well liked both times (well, I know I like it).
The tests it removes
- are missing an EXECKEEPSPID prerequisite on Windows
- use a : $((i = i + 1)) construct which does not seem to be portable
to old versions of dash
- are pointless, an eyesore, and a pain to maintain
What was the author thinking? Sorry to let this sit for so long.
Jonathan Nieder (1):
Revert "t0081 (line-buffer): add buffering tests"
t/t0081-line-buffer.sh | 106 +-----------------------------------------------
1 files changed, 2 insertions(+), 104 deletions(-)
[1] http://thread.gmane.org/gmane.comp.version-control.git/170307/focus=170365
[2] http://thread.gmane.org/gmane.comp.version-control.git/172120/focus=172523
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html