Jeff King wrote: > Yeah, that syntax is handled just fine by my bash and dash: > > $ cat >foo.sh <<'EOF' > i=1 > : $((i = $i + 1)) > echo $i > EOF > > $ bash foo.sh > 2 > $ bash --version | head -n 1 > GNU bash, version 4.1.5(1)-release (x86_64-pc-linux-gnu) > > $ dash foo.sh > 2 Er, ... yeah, it works for my bash and (up-to-date) dash too! [not the installed dash, of course, for which it is a syntax error] Ahem ... *blush* > But I think your i=$(($i + 1)) is the right solution. Yes, this fixes the problem and does not introduce a regression. So, the patch is correct, but (apart from the last sentence) the commit message is *absolute rubbish*. I won't bore you with the details of my lunacy! :-P However, I much prefer Jonathan's patch which removes this test completely! ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html