On Sun, May 15, 2011 at 6:42 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > I am not entirely happy about this change. The "ditto" refers to an ugly > workaround we had to add with 4f62c2b (log.decorate: only ignore it under > "log --pretty=raw", 2010-04-08) only because it was too late to revert the > change in 72d9b22 (Merge branch 'sd/log-decorate', 2010-05-08) that was > about to become part of 1.7.2-rc0 release. If we knew better, we probably > wouldn't have added the log.decorate variable that requires this hack that > requires us to say that 'log --pretty=raw' is special. > > If we stop before adding a new configuration, we do not have to repeat the > same mistake we made earlier. > > I dunno. I disagree that log.decorate is a mistake and that the workaround is ugly. It would be nice if we didn't need the workaround, but I don't think we should have to tie our hands because there are scripts that are parsing git log's output. I think it's a pragmatic solution to remaining backwards compatible while still being able to provide new functionality. FWIW, I use log.decorate, and I'd like to be able to use log.abbrevCommit. j. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html