Jay Soffian <jaysoffian@xxxxxxxxx> writes: > @@ -137,6 +139,12 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix, > && rev->commit_format == CMIT_FMT_RAW) > decoration_style = 0; > > + /* ditto for log.abbrevCommit */ > + if (!rev->abbrev_commit_given && rev->abbrev_commit > + && rev->commit_format == CMIT_FMT_RAW) > + rev->abbrev_commit = 0; > + > + I am not entirely happy about this change. The "ditto" refers to an ugly workaround we had to add with 4f62c2b (log.decorate: only ignore it under "log --pretty=raw", 2010-04-08) only because it was too late to revert the change in 72d9b22 (Merge branch 'sd/log-decorate', 2010-05-08) that was about to become part of 1.7.2-rc0 release. If we knew better, we probably wouldn't have added the log.decorate variable that requires this hack that requires us to say that 'log --pretty=raw' is special. If we stop before adding a new configuration, we do not have to repeat the same mistake we made earlier. I dunno. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html