Re: [PATCH 09/11] streaming: read non-delta incrementally from a pack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shawn Pearce <spearce@xxxxxxxxxxx> writes:

> On Sun, May 15, 2011 at 17:30, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> +static read_method_decl(pack_non_delta)
>
> I am not a huge fan of these decl macros... but I can see how writing
> out the same function prototype 3 times is annoying.

More importantly, it helped greatly while re-rolling this series literally
several times until I nailed the right set of parameters these methods
should take.

> I think the better strategy is to avoid delta compression altogether
> for objects that are so big we cannot materialize them as a contiguous
> buffer.

Yes, that is what I am aiming for in the recent topics around this area.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]