On Friday 13 May 2011 12:37:56 Jonathan Nieder wrote: > Christian Couder wrote: > > About writing files before each cherry-pick, I am not against it, if > > it is really needed to be safe. I even suggested it in my patch series > > back in November > > (http://article.gmane.org/gmane.comp.version-control.git/162183). > > But it will make cherry-pick less efficient, so it is a kind of > > performance regression that we can perhaps avoid by changing some > > die() into error(). > > Yes, that's a good point. Maybe in the long term the extra safety > could become optional. And I am happy about the die() elimination; > the only part I was not as thrilled about is relying on it. > > Some die() calls, like the one in xmalloc, would be very difficult to > eliminate. Yeah, but to address this problem, maybe we can use a special die routine like you already suggested. I think if we use both error() and a special die routine we should be pretty safe. Anyway I looked at the patch series and I found nothing that your very good review had not already spotted. My only nit is that maybe as the error handling patch is growing bigger, it could be splitted in 2 or 3 patchs. Thanks to you and Ram, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html