Re: [PATCHv1] git-p4: test harness directory handling tidyup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



luke@xxxxxxxxxxx wrote on Thu, 12 May 2011 06:14 +0100:
> The git-p4 test harness relied a lot on cd'ing to the target directory
> and then cd'ing back explicitly. That caused problems if the test failed
> partway through. i.e.
>   cd $git && stuff && cd "$TRASH_DIRECTORY"
> 
> Instead, use:
>   (cd $git && stuff)
> 
> Signed-off-by: Luke Diamand <luke@xxxxxxxxxxx>
> Suggested-by: Junio C Hamano <gitster@xxxxxxxxx>

I'm glad that Junio noticed and that you took the time to fix
this.  It was indeed a problem.

Acked-by: Pete Wyckoff <pw@xxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]