Felipe Contreras wrote: > On Tue, May 10, 2011 at 1:53 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> Â- the fix in sg/completion-updates is less likely to be broken by >> Â future changes in the bashcompinit library. > > How exactly? Because there remains the possibility that functions from bashcompinit will make use of the $words variable. I have said this about three times. It is not very likely, assuming the zsh developers want to keep supporting that fix (and I think they should), but the chance is there. >> Â- this fix is conceptually simpler. ÂIn a way, the fix in >> Â sg/completion-updates only works by accident. > > You are missing other advantages: Sorry, I should have prefaced the above with "in my opinion". And to be clear, I am not saying this fix should not be applied; I am just explaining the trade-offs as I understand them. The reason I asked for another opinion is that I find it hard to be objective in this case, because of another consideration I didn't mention: each moment I have been spending on this is an exercise in frustration. I even _like_ your fix (just like I _like_ GÃbor's cleanup and see no reason to contemplate the possibility of backing it out). So it's a shame. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html