Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > An alternative possibility if we need this fixed in the v1.7.5.x > series (do we?) would be cherry-picking the fix from > sg/completion-updates on top of maint. As contrib/ material, I personally don't think we would care strongly enough to bother. > To clarify the trade-offs: > > - in terms of lines of code, the fix itself in sg/completion-updates > and this fix are about the same size. But the sg/completion-updates > version relies on a code cleanup. > > - the fix in sg/completion-updates is less likely to be broken by > future changes in the bashcompinit library. > > - this fix is conceptually simpler. In a way, the fix in > sg/completion-updates only works by accident. Hmm, zsh does not want to see "word" getting localized by the user because it has a special semantics associated with it. Szeder avoids localizing it. Felipe sidesteps the issue by stripping the funny special semantics from the variable. I guess both have a similar degree of conceptual simplicity. One big thing going for this patch is that this is the blessed solution zsh folks themselves like to use, no? The repeated mention "zsh bashinit bug" in the code seems to suggest that it is the case. I do not mind reverting sg/completion-updates from 'next' (please remind me that I need to resurrect your "private shopt shim" separately if we go this route) and applying a cleaned-up version of this one. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html