Re: [PATCH] t/annotate-tests: Use echo & cat instead of sed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 04, 2011 at 10:39:55PM -0700, Junio C Hamano wrote:
> An earlier patch from Arjen Laarhoven
> 
>   From: Arjen Laarhoven <arjen@xxxxxxxx>
>   Subject: [PATCH] annotate.sh: Fix failing test on OS X
>   Date: Wed,  4 May 2011 15:36:21 +0200
>   Message-ID: <1304516181-92364-1-git-send-email-arjen@xxxxxxxx>
> 
> seems to attempt to address the same issue but with a twist to deal with
> an incomplete line at the end of file.
> 
> Arjen, does Brian's patch look good to you, too?  It is much less tricky
> and should look obviously correct even to people who sees the code in
> question for the first time.

Yup, this looks much better than my fix.  At least I learned something
about the sed incompatibilities ;-)

Arjen

-- 
Arjen Laarhoven

The presence of those seeking the truth is infinitely to be preferred to 
those who think they've found it.
                                -- Terry Pratchett, "Monstrous Regiment"

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]