Re: [PATCH V2 4/5] git-grep: Learn PCRE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05.05.2011 08:28:01 +0200 Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:

> Am 5/5/2011 0:00, schrieb MichaÅ Kiedrowicz:
> > +# Define NO_LIBPCRE if you do not have libpcre installed.
> 
> This makes libpcre a requirement with an opt-out. But I can imagine
> that there are many platforms where libpcre is not installed. We
> would have to add NO_LIBPRCE=1 to many platform configuration
> sections. But how can this setting be countermanded if someone does
> install libpcre on such a platform?
> 
> Wouldn't it be better to make this an opt-in (USE_LIBPCRE)?
> 
> -- Hannes

Yes, Junio already wrote that too. I'll change that.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]