On Mon, May 2, 2011 at 15:30, Thiago Farina <tfransosi@xxxxxxxxx> wrote:
> On Mon, May 2, 2011 at 8:39 AM, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote:
>> Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx>
>> ---
>> Âgrep.c | Â 42 +++++++++++++++++++++---------------------
>> Â1 files changed, 21 insertions(+), 21 deletions(-)
>>
>> diff --git a/grep.c b/grep.c
>> index b8eda9e..f21b022 100644
>> --- a/grep.c
>> +++ b/grep.c
>> @@ -437,7 +437,7 @@ static struct {
>> Â};
>>
>> Âstatic int match_one_pattern(struct grep_pat *p, char *bol, char *eol,
>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Âenum grep_context ctx,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Âunsigned lno, enum grep_context ctx,
>
> I'd rename lno to line_nr, so it's more clearer. Also, I'd add the new
> paramenter at the end, not in some random position (or was there some
> particular reason to put here but not in the end?).
lno is already in use in this file, so I followed here the precept.
The position was chosen, because bol/eol is the line content to match,
so the line number should probably be near the content parameter.
Bert
>
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â regmatch_t *pmatch, int eflags)
>> Â{
>> Â Â Â Âint hit = 0;
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html