Re: [PATCH/RFC 1/4] grep: prepare for re-using the space of the regexp member in struct grep_pat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 2, 2011 at 15:27, Thiago Farina <tfransosi@xxxxxxxxx> wrote:
> On Mon, May 2, 2011 at 8:39 AM, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote:
>> diff --git a/grep.h b/grep.h
>> index 06621fe..9912c11 100644
>> --- a/grep.h
>> +++ b/grep.h
>> @@ -32,7 +32,9 @@ struct grep_pat {
>> Â Â Â Âconst char *pattern;
>> Â Â Â Âsize_t patternlen;
>> Â Â Â Âenum grep_header_field field;
>> - Â Â Â regex_t regexp;
>> + Â Â Â union {
>> + Â Â Â Â Â Â Â regex_t regexp;
>> + Â Â Â } u;
>
> Instead of u, would be worth to rename it to something more descriptive?

I followed struct grep_expr, where u is also used. But I'm open for a
better name, if you have one.

Bert
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]