On Sun, Apr 10, 2011 at 10:54:17PM +0200, Erik Faye-Lund wrote: > strbuf_init does not zero-terminate the initial buffer when hint is > non-zero. Fix this so strbuf_attach does not return garbage. s/attach/detach/ I think. It is more than just detach, though; the NUL-termination is supposed to be an invariant of strbuf, so any code just looking at "sb.buf" would be broken. So your code looks fine, but you may want to mention that in the commit message. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html