Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 7, 2011 at 11:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:
>
>> Also the patch does not catch this (ie. not die() on unrecognized signature).
>
> Of course it doesn't.
>
> I didn't say "everything that is not alphanumeric is magic". I only said
> "all the magic are not alphanumeric". ÂNotice the difference.
>
>
> This is so that you can say ":/.gitignore" and do not have to say
> ":/:.gitignore".

But then, say people have a file named @foo at top dir. They can write
":/@foo" to address the file. Some time later we decide to use '@' as
magic, how can we re-train user's fingers?

> I am also tempted to special case a ':' followed by a zero magic as if it
> specifies the top magic, e.g. ":Makefile" is the same as ":(top)Makefile",
> aka ":/Makefile". ÂIt is not in the published code, but the short-cut
> would help ":.gitignore".

If you're not too tempted to do it, then reserve the case (ie. die()).
Although I quite like it, one less keystroke for me.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]