Re: [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:

> Also the patch does not catch this (ie. not die() on unrecognized signature).

Of course it doesn't.

I didn't say "everything that is not alphanumeric is magic". I only said
"all the magic are not alphanumeric".  Notice the difference.


This is so that you can say ":/.gitignore" and do not have to say
":/:.gitignore".

I am also tempted to special case a ':' followed by a zero magic as if it
specifies the top magic, e.g. ":Makefile" is the same as ":(top)Makefile",
aka ":/Makefile".  It is not in the published code, but the short-cut
would help ":.gitignore".

You don't require, nor allowed to have, a colon after ')' when writing a
long hand, by the way.  There is no reason to require one for disambiguation.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]