On Wed, 30 Mar 2011 12:09:46 +0200, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: > On Tue, Mar 29, 2011 at 5:28 PM, Michael Witten <mfwitten@xxxxxxxxx> wrote: >> +#define ALT_ODB_FN_INFO_FUNC(variable, function) \ >> + union alt_odb_fn_info variable = { \ >> + .func = (alt_odb_fn_cb)function \ >> + } >> +#define ALT_ODB_FN_INFO_DATA(variable, data_) \ >> + union alt_odb_fn_info variable = { \ >> + .data = data_ \ >> + } > > We try to stay away from C99 features like this, as it doesn't work on > all compilers we target. How about changing it to this: #define ALT_ODB_FN_INFO_FUNC(variable, function) \ union alt_odb_fn_info variable; do { \ variable.func = (alt_odb_fn_cb)function; \ } while (0) #define ALT_ODB_FN_INFO_DATA(variable, data_) \ union alt_odb_fn_info variable; do { \ variable.data = data_ \ } while (0) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html