Jens Lehmann wrote: > Am 16.03.2011 08:14, schrieb Jonathan Nieder: >> Introduce two functions: >> >> - prepare_submodule_summary prepares the revision walker >> to list changes in a submodule. That is, it: >> >> * finds merge bases between the commits pointed to this >> path from before ("left") and after ("right") the change; pointed to at this path before [missing "at", spurious "from"] >> * checks whether this is a fast-forward or fast-backward; >> * prepares a revision walk to list commits in the symmetric >> difference between the commits at each endpoint. >> >> It returns nonzero on error. >> >> - print_submodule_summary runs the revision walk and saves >> the result to a strbuf in --left-right format. runs the revision walk and prints the result in --left-right format [the strbuf is an implementation detail; not sure how it snuck into the commit message] >> The goal is just readability. No functional change intended. > > Ack, looks good and makes sense to me. Thanks, Jens. Looking back over the commit message I see I left in some typos but the patch still looks good to me fwiw. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html