Here are some more patches in the same vein.
Patches 1-4 fix style problems noticed with make CC="c89 -pedantic"
(mostly concerning the -pedantic rather than the c89).
Patch 5 updates fast-import.c (and everyone else) to put braces on the
same line as "struct foo" --- the waste of space had bothered me every
time I hacked on fast-import.c so now is my chance. :)
Patches 6-8 factor out some new functions to un-indent code a little.
The indented code was discovered in changing
struct pretty_print_ctx ctx = {0};
into something more verbose to appease gcc -Wmissing-field-initializers,
which probably wasn't a good idea after all. :) But the by-product is
nice.
Jonathan Nieder (8):
enums: omit trailing comma for portability
compat: make gcc bswap an inline function
svn-fe: do not use "return" for tail call returning void
vcs-svn: remove spurious semicolons
standardize brace placement in struct definitions
branch: split off function that writes tracking info and commit
subject
cherry: split off function to print output lines
diff --submodule: split into bite-sized pieces
builtin/add.c | 3 +-
builtin/blame.c | 3 +-
builtin/branch.c | 48 +++++++++++++----------
builtin/grep.c | 3 +-
builtin/index-pack.c | 6 +--
builtin/log.c | 34 +++++++++--------
cache.h | 2 +-
commit.h | 3 +-
compat/bswap.h | 18 +++++----
config.c | 3 +-
convert.c | 2 +-
diff.c | 6 +--
fast-import.c | 42 +++++++-------------
http-push.c | 15 ++-----
http-walker.c | 6 +--
http.h | 15 ++-----
merge-recursive.c | 12 ++----
pack-check.c | 3 +-
string-list.h | 3 +-
submodule.c | 103 +++++++++++++++++++++++++++++--------------------
transport-helper.c | 3 +-
vcs-svn/repo_tree.c | 2 +-
vcs-svn/string_pool.c | 2 +-
vcs-svn/svndump.c | 3 +-
24 files changed, 164 insertions(+), 176 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html