Re: [PATCH 1/3] make_absolute_path: Don't try to copy a string to itself

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Carlos MartÃn Nieto <cmn@xxxxxxxx> writes:

> On mar, 2011-03-15 at 12:59 +0100, Carlos MartÃn Nieto wrote:
>> On lun, 2011-03-14 at 15:58 -0700, Junio C Hamano wrote:
>> > Carlos MartÃn Nieto <cmn@xxxxxxxx> writes:
> [...]
>> > 
>> > >  There is however the extra functionality the function offers, namely
>> > > resolving links. It might be good to split it into two functions so each
>> > > caller can specify what it wants.
>> > 
>> > Probably.
>> 
>>  With the changes mentioned earlier, if you want an absolute pathname,
>> you'd call absolute_path/make_nonrelative_path and if you want to make
>> sure you have the real path of the target file, you'd use real_path just
>> as you'd use realpath on a sane system, with
>
>  ... a comment on the functions and maybe some documentation in
> Documentation/techncal, as it doesn't seem to exist yet.

We probably should involve Nguyán in this thread as his fingers are
everywhere on the codepaths related to setup.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]