On Sun, 19 Nov 2006, Junio C Hamano wrote: > > Did you do this "if (isspace(*line)) return NULL" to have > extensibility later, I wonder... No, but I try to have a policy of not accepting anything that is even slightly questionable, so it was unintentional in the details but a result of a higher-level principle.. Of course, even when I wrote it I _also_ knew that I should check everything else too (not just the first character), but I was lazy. That would have been even better - then we could have made the thing be something like <sha1><space><name>[<space><sha1-of-deref>]* instead. Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html