On Wed, 23 Feb 2011, Ãvar ArnfjÃrà Bjarmason wrote: > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (strcmp(n->tag->tag, all ? n->path + 5 : n->path)) > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂwarning("tag '%s' is really '%s' here", n->tag->tag, n->path); > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂwarning(_("tag '%s' is really '%s' here"), n->tag->tag, n->path); > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂn->name_checked = 1; > ÂÂÂÂÂÂÂÂ} Don't we need to use order notation to be able to change order of those two parameters, i.e. use + warning(_("tag '%1$s' is really '%2$s' here"), n->tag->tag, n->path); Perhaps also some comment for translators describing placeholders? -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html