On Thu, Feb 24, 2011 at 3:28 PM, Jeff King <peff@xxxxxxxx> wrote: > +int trace_want(const char *key) > +{ > + const char *trace = getenv(key); > + > + if (!trace || !strcmp(trace, "") || > + !strcmp(trace, "0") || !strcasecmp(trace, "false")) > + return 0; > + return 1; > +} Other minor nit: calling it "trace_wanted()" or "want_trace()" looks better to me. Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html