On Thu, Feb 24, 2011 at 04:05:13PM +0100, Christian Couder wrote:
> > + Â Â Â len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, cp);
> > + Â Â Â va_end(cp);
> > Â Â Â Âif (len < 0)
> > - Â Â Â Â Â Â Â die("your vsnprintf is broken");
> > + Â Â Â Â Â Â Â die("BUG: your vsnprintf is broken (returned -1)");
>
> Minor nit: why not:
>
> + die("BUG: your vsnprintf is broken (returned %d)", len);
No reason. I'll switch to yours in my re-roll.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html