Guy Rouillier <guyr@xxxxxxxxxxxxx> writes: > On 2/20/2011 2:21 AM, Junio C Hamano wrote: > ... >> In practice, I would imagine that the cvsroot part wouldn't contain an >> equal sign, so this looser regexp would not hurt in the real life, but it >> does feel yucky. > > Well, this is the important point. I did think of these aspects when > writing the code. Sure, writing more precise code is possible, but the > results are the same in either case. It is probably unlikely to see a SP in the pathname, but I do not think it is reasonable to introduce a regression to forbid '=' in the pathname to the repository, which we have been supporting since August 2009, when we know the patch as-is will regress the use case, and especially when we already know a way to code not to regress is not too complex. The "substitute with 'A' when missing" comes from e481b1d (cvs: initialize empty password, 2009-09-17); it makes me worried that the patch is removing the support, _unless_ that commit by Clemens was addressing a problem that does not exist (and if so, I'd like to see a sentence or two in the commit log to explain why it is a sane thing to do to remove it). Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html