Re: [PATCH 6/7] tag: support column output with --column

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/2/10 Junio C Hamano <gitster@xxxxxxxxx>:
> Nguyán ThÃi Ngác Duy Â<pclouds@xxxxxxxxx> writes:
>
>> @@ -52,7 +54,7 @@ static int show_reference(const char *refname, const unsigned char *sha1,
>> Â Â Â Â Â Â Â }
>>
>> Â Â Â Â Â Â Â if (!filter->lines) {
>> - Â Â Â Â Â Â Â Â Â Â printf("%s\n", refname);
>> + Â Â Â Â Â Â Â Â Â Â string_list_append(&layout.items, refname);
>
> Hmm, is this robbing streaming output from people who do not care about
> columnar output?

Yes, but tag list is short enough streaming does not really matter. I
can check if column mode is active there, if it's not, just printf.

> I tend to agree with others who suggested you to port column to platforms
> that lack it.

The first version of this series created git-column and made a pipe to
git-column when column output is active. I'll resurrect the command
then. Original column does not understand ANSI escape codes for
coloring and mess up column output.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]